On Tue, 21 Mar 2023 15:38:31 +0100 Wolfram Sang wrote: > > > struct smsc911x_data *pdata = netdev_priv(dev); > > > - struct phy_device *phydev = NULL; > > > + struct phy_device *phydev; > > > int ret; > > > > > > phydev = phy_find_first(pdata->mii_bus); > > > > Nit: perhaps combine this assignment with the variable declaration? > > I thought about it but found this version to be easier readable. +1 Calling functions which need their return value error-checked as part of the variable declaration should be against the kernel coding style IMHO.
