Re: [PATCH net-next] ethernet: remove superfluous clearing of phydev

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx
Subject: Re: [PATCH net-next] ethernet: remove superfluous clearing of phydev
From: Florian Fainelli <f.fainelli@xxxxxxxxx>
Date: Tue, 21 Mar 2023 13:38:57 -0700
Cc: linux-renesas-soc@xxxxxxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Bryan Whitehead <bryan.whitehead@xxxxxxxxxxxxx>, UNGLinuxDriver@xxxxxxxxxxxxx, Sergey Shtylyov <s.shtylyov@xxxxxx>, Steve Glendinning <steve.glendinning@xxxxxxxxxxx>, Wells Lu <wellslutw@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20230321131745.27688-1-wsa+renesas@sang-engineering.com>
References: <20230321131745.27688-1-wsa+renesas@sang-engineering.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1

On 3/21/23 06:17, Wolfram Sang wrote:

phy_disconnect() calls phy_detach() which already clears 'phydev' if it
is attached to a struct net_device.

Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>


Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
--
Florian

References:
- [PATCH net-next] ethernet: remove superfluous clearing of phydev
  - From: Wolfram Sang

Prev by Date: Re: [PATCH net-next] ethernet: remove superfluous clearing of phydev
Next by Date: Re: [PATCH v2] dt-bindings: display: Drop unneeded quotes
Previous by thread: Re: [PATCH net-next] ethernet: remove superfluous clearing of phydev
Next by thread: Re: [PATCH net-next] ethernet: remove superfluous clearing of phydev
Index(es):
- Date
- Thread

[Index of Archives] [Linux Samsung SOC] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Samba] [Device Mapper]