Re: [PATCH net-next] ethernet: remove superfluous clearing of phydev

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH net-next] ethernet: remove superfluous clearing of phydev
From: Andrew Lunn <andrew@xxxxxxx>
Date: Tue, 21 Mar 2023 21:17:28 +0100
Cc: netdev@xxxxxxxxxxxxxxx, linux-renesas-soc@xxxxxxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Bryan Whitehead <bryan.whitehead@xxxxxxxxxxxxx>, UNGLinuxDriver@xxxxxxxxxxxxx, Sergey Shtylyov <s.shtylyov@xxxxxx>, Steve Glendinning <steve.glendinning@xxxxxxxxxxx>, Wells Lu <wellslutw@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20230321131745.27688-1-wsa+renesas@sang-engineering.com>
References: <20230321131745.27688-1-wsa+renesas@sang-engineering.com>

On Tue, Mar 21, 2023 at 02:17:45PM +0100, Wolfram Sang wrote:
> phy_disconnect() calls phy_detach() which already clears 'phydev' if it
> is attached to a struct net_device.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew

References:
- [PATCH net-next] ethernet: remove superfluous clearing of phydev
  - From: Wolfram Sang

Prev by Date: Re: [PATCH v4] dt-bindings: iommu: renesas, ipmmu-vmsa: Update for R-Car Gen4
Next by Date: Re: [PATCH net-next] ethernet: remove superfluous clearing of phydev
Previous by thread: [PATCH net-next] ethernet: remove superfluous clearing of phydev
Next by thread: Re: [PATCH net-next] ethernet: remove superfluous clearing of phydev
Index(es):
- Date
- Thread

[Index of Archives] [Linux Samsung SOC] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Samba] [Device Mapper]