Hello Wolfram, > -----Original Message----- > From: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > Sent: 2023年3月14日 21:15 > To: netdev@xxxxxxxxxxxxxxx > Cc: linux-renesas-soc@xxxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; Wolfram Sang > <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>; Wei Fang <wei.fang@xxxxxxx>; > Shenwei Wang <shenwei.wang@xxxxxxx>; Clark Wang > <xiaoning.wang@xxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>; David S. > Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; > Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; > linux-kernel@xxxxxxxxxxxxxxx > Subject: [PATCH net-next 3/4] fec: add FIXME to move 'mac_managed_pm' to > probe > > On Renesas hardware, we had issues because the above flag was set during > 'open'. It was concluded that it needs to be set during 'probe'. It looks like FEC > needs the same fix but I can't test it because I don't have the hardware. At > least, leave a note about the issue. > Could you describe this issue in more details? So that I can reproduce and fix this issue and test it. Thanks! > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > --- > drivers/net/ethernet/freescale/fec_main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/freescale/fec_main.c > b/drivers/net/ethernet/freescale/fec_main.c > index c73e25f8995e..b16f56208d66 100644 > --- a/drivers/net/ethernet/freescale/fec_main.c > +++ b/drivers/net/ethernet/freescale/fec_main.c > @@ -2318,6 +2318,7 @@ static int fec_enet_mii_probe(struct net_device > *ndev) > fep->link = 0; > fep->full_duplex = 0; > > + /* FIXME: should be set right after mdiobus is registered */ > phy_dev->mac_managed_pm = true; > > phy_attached_info(phy_dev); > -- > 2.30.2
