Hi Andy Shevchenko,
Thanks for the feedback.
> Subject: Re: [PATCH v6 03/13] pinctrl: Add sysfs support
>
> Mon, Mar 06, 2023 at 09:00:04AM +0000, Biju Das kirjoitti:
> > Add a simple sysfs interface to the generic pinctrl framework for
> > configuring pins for output disable operation.
> >
> > /sys/class/pinctrl/
> > `-- output-disable/
> > |-- configure (w/o) ask the kernel to configure a pin group
> > for output disable operation.
> >
> > echo "<group-name function-name 0 1>" > configure
> >
> > The existing "pinmux-functions" debugfs file lists the pin functions
> > registered for the pin controller. For example:
> >
> > function 0: usb0, groups = [ usb0 ]
> > function 1: usb1, groups = [ usb1 ]
> > function 2: gpt4-pins, groups = [ gpt4-pins ]
> > function 3: scif0, groups = [ scif0 ]
> > function 4: scif2, groups = [ scif2 ]
> > function 5: spi1, groups = [ spi1 ]
> >
> > To configure gpt4-pins for output disable activation by user:
> >
> > echo "gpt4-pins gpt4-pins 0 1" > configure
>
> ...
>
> > +static struct attribute *pinctrl_attrs[] = {
> > + &dev_attr_configure.attr,
> > + NULL,
>
> No comma for a terminator entry.
Agreed.
Cheers,
Biju
