Hi Andy Shevchenko, Thanks for the feedback. > Subject: Re: [PATCH v6 01/13] pinctrl: core: Add pinctrl_get_device() > > Mon, Mar 06, 2023 at 09:00:02AM +0000, Biju Das kirjoitti: > > Add pinctrl_get_device() to find a device handle associated with a > > pincontrol group(i.e. by matching function name and group name for a > > device). This device handle can then be used for finding match for the > > pin output disable device that protects device against short circuits > > on the pins. > > Not sure I understand the use case. Please, create a better commit message. OK, Basically pinmux_enable_setting allows exclusive access of pin to a device. It won't allow multiple devices to claim a pin. Maybe instead of find device handle, it should re worded as to find the current owner of the pins associated with a given function and group name?? Or please let me know have better suggestion. Then use this info for matching the device used for pin output disable. > > Also it is missing the explanation why there will be no collisions when > looking by the same pair of function and group name from different device. setting->data.mux will be unique for a pin. So there won't be a collision when looking by the same pair of function and group name from different device. > > (Always imagine that you have 2+ same IP blocks on the platform before doing > any pin control core work. This will help you to design it properly. ) OK. Cheers, Biju
