Hi Niklas, Laurent,
On Sat, Feb 11, 2023 at 5:58 PM Niklas Söderlund
<niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> From: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
>
> The Draak board has an ADV7180 CVBS decoder and an ADV7612 HDMI decoder,
> both connected to the same VIN input. DIP switches are used to select
> one of the two devices, with the HDMI decoder being the default. Add an
> overlay that selects the CVBS decoder.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> [Niklas: Inverted it from HDMI to CVBS]
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
Thanks for your patch!
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/draak-cvbs-input.dtso
> @@ -0,0 +1,33 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright 2023 Ideas on Board Oy
> + *
> + * Device tree overlay for the Draak board, to enable CVBS input. This requires
> + * setting DIP switches SW49, SW50, SW51 and SW52 to OFF, and SW53 and SW54 to
> + * ON.
> + */
> +
> +/dts-v1/;
> +/plugin/;
> +
> +&adv7180_out {
> + remote-endpoint = <&vin4_in>;
> +};
[...]
> +&vin4_in {
> + remote-endpoint = <&adv7180_out>;
> +};
Unfortunately dtc doesn't like references to nodes it cannot find the
names of:
arch/arm64/boot/dts/renesas/draak-cvbs-input.dtbo: Warning
(graph_port): /fragment@0: graph port node name should be 'port'
arch/arm64/boot/dts/renesas/draak-cvbs-input.dtbo: Warning
(graph_port): /fragment@2: graph port node name should be 'port'
arch/arm64/boot/dts/renesas/draak-cvbs-input.dtso:13.14-15.3:
Warning (graph_endpoint): /fragment@0/__overlay__: graph endpoint node
name should be 'endpoint'
arch/arm64/boot/dts/renesas/draak-cvbs-input.dtso:27.10-29.3:
Warning (graph_endpoint): /fragment@2/__overlay__: graph endpoint node
name should be 'endpoint'
Do you think it would be worthwhile to add more hierarchy (like in
arch/arm64/boot/dts/renesas/draak-ebisu-panel-aa104xd12.dtso), to get
rid of the dtc warnings?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
