Hi Niklas,
On Sat, Feb 11, 2023 at 4:06 PM Niklas Söderlund
<niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> Add support for C-PHY on R-Car V4H. While the V4H supports both D-PHY
> and C-PHY this patch only adds support for the C-PHY mode due to lack of
> documentation and hardware to test on.
>
> The V4H is the first Gen4 device that is enabled in the rcar-csi2
> driver. There is much overlap with the Gen3 driver, the primary
> difference is in how the receiver is started. The V4H have a much larger
> register space and some addresses overlap with Gen3.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
Thanks for your patch!
> --- a/drivers/media/platform/renesas/rcar-vin/rcar-csi2.c
> +++ b/drivers/media/platform/renesas/rcar-vin/rcar-csi2.c
> @@ -1503,6 +1781,12 @@ static const struct rcar_csi2_info rcar_csi2_info_r8a779a0 = {
> .support_dphy = true,
> };
>
> +static const struct rcar_csi2_info rcar_csi2_info_r8a779g0 = {
> + .start_receiver = rcsi2_start_receiver_v4h,
The description of "[PATCH 1/3] media: rcar-csi2: Prepare for Gen4
support" suggests you also need a different procedure for
.enter_standby()? But perhaps not doing the procedure is just the right
thing to do?
> + .use_isp = true,
> + .support_cphy = true,
> +};
> +
> static const struct of_device_id rcar_csi2_of_table[] = {
> {
> .compatible = "renesas,r8a774a1-csi2",
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
