Hi Morimoto-san, On Thu, Feb 2, 2023 at 2:04 AM Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > These adds R-Car Sound support for WhiteHawk board using ARD-AUDIO-DA7212 > external audio board. > > Signed-off-by: Linh Phung <linh.phung.jy@xxxxxxxxxxx> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> Thanks for your patch! > --- /dev/null > +++ b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-ard-audio-da7212.dts > @@ -0,0 +1,194 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Device Tree Source for the White Hawk boards with R-Car V4H + ARD-AUDIO-DA7212 Board > + * > + * You can find and buy "ARD-AUDIO-DA7212" at Digi-Key > + * > + * https://www.digikey.jp/en/products/detail/ARD-AUDIO-DA7212/1564-1021-ND/5456357?curr=usd&utm_campaign=buynow&utm_medium=aggregator&utm_source=octopart Please drop the question mark and everything after it from the URL. > + * [Connection] > + * > + * White Hawk ARD-AUDIO-DA7212 > + * +----------------------------+ > + * |CPU board | > + * | | > + * |CN40 (IO PIN HEADER) | > + * | AUDIO_CLKIN_V pin1 |<--\ +---------------+ > + * |(*) GP1_25/SL_SW2_V pin2 |<--/ |J2 | > + * | AUDIO_CLKOUT_V pin5 |<----->| pin7 MCLK | > + * | SSI_SCK_V pin9 |<----->| pin1 BCLK | > + * | SSI_WS_V pin13 |<----->| pin3 WCLK | > + * | SSI_SD_V pin15 |<----->| pin5 DATIN | (@) > + * | | \-->| pin15 DATOUT | [CAPTURE] > + * +----------------------------+ +---------------+ > + * (*) GP1_25/SL_SW2_V is used as TPU > + * (@) Connect to pin5 (DATIN = playback) or pin15 (DATOUT = capture) > + * > + * +----------------------------+ > + * |Breakout board | > + * | | +---------------+ > + * |CN34 (I2C CN) | |J1 | > + * | I2C0_SCL pin3 |<----->| pin20 SCL | > + * | I2C0_SDA pin5 |<----->| pin18 SDA | > + * +----------------------------+ +--->| pin14 GND | > + * | +---------------+ > + * +----------------------------+ | > + * |Switch Board | | > + * | | | +---------------+ > + * |CN5 GND |<-+ |J7 | Probably it would be more logical to wire GND to pin 14 of J7 (which is the power connector) instead? Doesn't matter much though, as all GND signals are connected to each other. > + * | 3v3 |<----->| pin8 (+3.3v) | Do you need the Switch Board? GND and SPI_D1.8V/3.3V and I2C_D1.8V/3.3V (which are 3.3V by default) are available on CN40 and CN34 above, too. > +/dts-v1/; > +#include "r8a779g0-white-hawk.dts" Please do not include "r8a779g0-white-hawk.dts", but make this file a .dtso (DTS overlay) instead, cfr. salvator-panel-aa104xd12.dtso. > +&i2c0 { > + da7212: codec@1a { > + compatible = "dlg,da7212"; > + > + #sound-dai-cells = <0>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + reg = <0x1a>; > + > + clocks = <&rcar_sound>; > + clock-names = "mclk"; > + > + dlg,micbias1-lvl = <2500>; > + dlg,micbias2-lvl = <2500>; > + dlg,dmic-data-sel = "lrise_rfall"; > + dlg,dmic-samplephase = "between_clkedge"; > + dlg,dmic-clkrate = <3000000>; > + > + VDDA-supply = <®_1p8v>; > + VDDSP-supply = <®_5p0v>; As the wiring above does not provide VDD_SP (which is fine if the speaker is not connected), you can drop VDDSP-supply, and [PATCH 6/9] providing reg_5p0v. FTR, "VDDSP-supply" is not documented in the DA7212 DT bindings. > + VDDMIC-supply = <®_3p3v>; > + VDDIO-supply = <®_3p3v>; > + > + port@0 { > + da7212_endpoint: endpoint { > + remote-endpoint = <&rsnd_endpoint>; > + }; > + }; > + }; > +}; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
