Re: [PATCH v2] dt-bindings: leds: Document Bluetooth and WLAN triggers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 26/01/2023 21:46, Luiz Augusto von Dentz wrote:
> Hi Lee,
> 
> On Thu, Jan 26, 2023 at 12:00 AM Lee Jones <lee@xxxxxxxxxx> wrote:
>>
>> On Wed, 25 Jan 2023, Luiz Augusto von Dentz wrote:
>>
>>> Hi Lee,
>>>
>>> On Wed, Jan 25, 2023 at 7:16 AM Lee Jones <lee@xxxxxxxxxx> wrote:
>>>>
>>>> On Tue, 24 Jan 2023, patchwork-bot+bluetooth@xxxxxxxxxx wrote:
>>>>
>>>>> Hello:
>>>>>
>>>>> This patch was applied to bluetooth/bluetooth-next.git (master)
>>>>> by Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>:
>>>>>
>>>>> On Sun, 22 Jan 2023 11:47:27 +0100 you wrote:
>>>>>> Add the missing trigger patterns for Bluetooth and WLAN activity, which
>>>>>> are already in active use.
>>>>>>
>>>>>> While at it, move the mmc pattern comment where it belongs, and restore
>>>>>> alphabetical sort order.
>>>>>>
>>>>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>>>>>> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
>>>>>>
>>>>>> [...]
>>>>>
>>>>> Here is the summary with links:
>>>>>   - [v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
>>>>>     https://git.kernel.org/bluetooth/bluetooth-next/c/ef017002b93b
>>>>
>>>> Why are you taking LED patches through the Bluetooth tree?
>>>
>>> I assume there isn't a tree dedicated to dt-bindings/leds
>>
>> % ./scripts/get_maintainer.pl -f Documentation/devicetree/bindings/leds/common.yaml
>>  Pavel Machek <pavel@xxxxxx> (maintainer:LED SUBSYSTEM,in file)
>>  Lee Jones <lee@xxxxxxxxxx> (maintainer:LED SUBSYSTEM)
>>  Rob Herring <robh+dt@xxxxxxxxxx> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>>  Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>>  Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx> (in file)
>>  linux-leds@xxxxxxxxxxxxxxx (open list:LED SUBSYSTEM)
>>  devicetree@xxxxxxxxxxxxxxx (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>>  linux-kernel@xxxxxxxxxxxxxxx (open list)
> 
> Well this doesn't tell us what parts of the dt_bindings have a
> dedicated tree and which doesn't, 

There is no such "parts" anywhere. I don't understand that remark and
how is related here. This is a list of maintainers for this file. Why
information are you missing in MAINTAINERS? And why bindings would be
special (e.g. you don't miss this information for other parts of kernel)?

>>
>>> anyway I'd be happy if the dt-bindings patches
>>> would be handled elsewhere.
>>
>> Yep, we got this. :)
> 
> So if it starts with dt-binding: prefix shall we ignore? Or is just
> for dt-bindings: leds? Or perhaps we can just ignore patches received
> as CC: rather than directly To: field.

What was exactly unclear in my response? The bindings for your subsystem
are for you. Bindings for other subsystems are not for you. dt-bindings:
leds: are for leds suubsystem. dt-bindings: mfd: are for mfd subsystem.
If the prefix is incorrect because people make mistakes, the paths point
to it - Documentation/devicetree/bindings/SUBSYSTEM_OR_HARDWARE_CLASS/....


Best regards,
Krzysztof




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux