On Tue, Jan 03, 2023 at 07:56:41PM +0200, Vladimir Oltean wrote: > On Mon, Jan 02, 2023 at 09:14:00PM -0800, Colin Foster wrote: > > diff --git a/Documentation/devicetree/bindings/net/ethernet-switch-port.yaml b/Documentation/devicetree/bindings/net/ethernet-switch-port.yaml > > new file mode 100644 > > index 000000000000..126bc0c12cb8 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/ethernet-switch-port.yaml > > @@ -0,0 +1,25 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/ethernet-switch-port.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Generic Ethernet Switch Port > > + > > +maintainers: > > + - Andrew Lunn <andrew@xxxxxxx> > > + - Florian Fainelli <f.fainelli@xxxxxxxxx> > > + - Vladimir Oltean <olteanv@xxxxxxxxx> > > + > > +description: > > + Ethernet switch port Description > > Still doesn't look too great that the ethernet-switch-port description > is this thing devoid of meaning. What is said about the dsa-port is what > the description should be here, and the description of the dsa-port is > that it's a generic Ethernet switch port plus DSA specific properties. Apologies - you mentioned this earlier as well. I'm not sure how I missed it in v5 (and therefore v6) > > > + > > +$ref: ethernet-controller.yaml# > > + > > +properties: > > + reg: > > + description: Port number > > + > > +additionalProperties: true > > Also, I see your patches are deferred in patchwork, and while this isn't > really for me to say, presumably it's because there was no announcement > so far that net-next reopened. Based on above, it might be for the better.
