RE: [PATCH] arm64: dts: renesas: rzg2l-smarc: Enable ADV7535 on carrier board

[Biju Das <biju.das.jz@xxxxxxxxxxxxxx>]

Hi Geert,

Thanks for the feedback.

> Subject: Re: [PATCH] arm64: dts: renesas: rzg2l-smarc: Enable ADV7535 on
> carrier board
> 
> Hi Biju,
> 
> Thanks for your patch!
> 
> On Tue, Nov 22, 2022 at 8:55 PM Laurent Pinchart
> <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
> > On Tue, Nov 22, 2022 at 07:41:13PM +0000, Biju Das wrote:
> > > > Subject: Re: [PATCH] arm64: dts: renesas: rzg2l-smarc: Enable
> > > > ADV7535 on carrier board On Tue, Nov 22, 2022 at 06:58:02PM +0000,
> > > > Biju Das wrote:
> > > > > Enable ADV7535 (MIPI DSI Receiver with HDMI Transmitter) on
> > > > > RZ/G2L SMARC EVK.
> > > > >
> > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> 
> > > > > --- a/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
> > > > > +++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
> 
> > > > > +&i2c1 {
> > > > > + pinctrl-0 = <&i2c1_pins>;
> > > > > + pinctrl-names = "default";
> > > > > +
> > > > > + status = "okay";
> 
> pinctrl and status are already set by rz-smarc-common.dtsi?

OK , will take out this.

> 
> > > > > +
> > > > > + adv7535: hdmi@3d {
> > > > > +         compatible = "adi,adv7535";
> > > > > +         reg = <0x3d>;
> > > > > +
> > > > > +         avdd-supply = <&reg_1p8v>;
> > > > > +         dvdd-supply = <&reg_1p8v>;
> > > > > +         pvdd-supply = <&reg_1p8v>;
> > > > > +         a2vdd-supply = <&reg_1p8v>;
> > > > > +         v3p3-supply = <&reg_3p3v>;
> > > > > +         v1p2-supply = <&reg_1p8v>;
> > > > > +
> > > > > +         adi,dsi-lanes = <4>;
> 
> Missing clocks/clock-names (OSC1, 12 MHz).
OK, will add this.
> Missing interrupts (P2_1).

So far, I am testing with polling mode. OK will add interrupts and test.

> 
> > > > > +
> > > > > +         ports {
> > > > > +                 #address-cells = <1>;
> > > > > +                 #size-cells = <0>;
> > > > > +
> > > >
> > > > How about port@0 ? That's the DSI input, I expect it should be
> > > > connected to the DSI encoder output.
> > >
> > > Yes, I will enable DSI node and link with port@0.  Since both RZ/G2L
> > > and RZ/V2L uses same Carrier board, I need to send binding patch for
> RZ/V2L.
> > >
> > > dts Patches for enabling DSI for RZ/G2L ready. But V2L there is
> dependency on bindings.
> 
> That's just a matter of days, right?

Yes, I have already posted the patch [1]
[1] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20221122195413.1882486-1-biju.das.jz@xxxxxxxxxxxxxx/

> 
> > > If you prefer both ports together, then I can defer this later.
> >
> > It could be easier to review (not to mention testing). I'll let Geert
> > decide.
> 
> Is there any advantage in applying this patch now, i.e. does it enable
> any working functionality?

Currently all display/graphics functionality tested with [3]

The advantage is, 

1) I would like to backport graphics and display functionality to cip kernel [2]
   as most of our customers are using this kernel.

2) we can test ADV driver using i2c read/write command

3) We can test ADV interrupts

4) This will reduce integration effort as we can test full display and graphics
  functionality with [3]

[2] https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-5.10.y-cip
[3] https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=698606

Please share your views.

Cheers,
Biju