Re: [PATCH] arm64: dts: renesas: rzg2l-smarc: Enable ADV7535 on carrier board

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Biju,

Thanks for your patch!

On Tue, Nov 22, 2022 at 8:55 PM Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
> On Tue, Nov 22, 2022 at 07:41:13PM +0000, Biju Das wrote:
> > > Subject: Re: [PATCH] arm64: dts: renesas: rzg2l-smarc: Enable ADV7535 on
> > > carrier board
> > > On Tue, Nov 22, 2022 at 06:58:02PM +0000, Biju Das wrote:
> > > > Enable ADV7535 (MIPI DSI Receiver with HDMI Transmitter) on RZ/G2L
> > > > SMARC EVK.
> > > >
> > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>

> > > > --- a/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
> > > > +++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi

> > > > +&i2c1 {
> > > > + pinctrl-0 = <&i2c1_pins>;
> > > > + pinctrl-names = "default";
> > > > +
> > > > + status = "okay";

pinctrl and status are already set by rz-smarc-common.dtsi?

> > > > +
> > > > + adv7535: hdmi@3d {
> > > > +         compatible = "adi,adv7535";
> > > > +         reg = <0x3d>;
> > > > +
> > > > +         avdd-supply = <&reg_1p8v>;
> > > > +         dvdd-supply = <&reg_1p8v>;
> > > > +         pvdd-supply = <&reg_1p8v>;
> > > > +         a2vdd-supply = <&reg_1p8v>;
> > > > +         v3p3-supply = <&reg_3p3v>;
> > > > +         v1p2-supply = <&reg_1p8v>;
> > > > +
> > > > +         adi,dsi-lanes = <4>;

Missing clocks/clock-names (OSC1, 12 MHz).
Missing interrupts (P2_1).

> > > > +
> > > > +         ports {
> > > > +                 #address-cells = <1>;
> > > > +                 #size-cells = <0>;
> > > > +
> > >
> > > How about port@0 ? That's the DSI input, I expect it should be connected
> > > to the DSI encoder output.
> >
> > Yes, I will enable DSI node and link with port@0.  Since both RZ/G2L and RZ/V2L
> > uses same Carrier board, I need to send binding patch for RZ/V2L.
> >
> > dts Patches for enabling DSI for RZ/G2L ready. But V2L there is dependency on bindings.

That's just a matter of days, right?

> > If you prefer both ports together, then I can defer this later.
>
> It could be easier to review (not to mention testing). I'll let Geert
> decide.

Is there any advantage in applying this patch now, i.e. does it enable
any working functionality?

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds