On 18/11/2022 14:16, Biju Das wrote:
> Add device tree bindings for the RZ/V2{M, MA} PWM Timer (PWM).
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
Thank you for your patch. There is something to discuss/improve.
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> + - power-domains
> +
> +if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - renesas,r9a09g055-pwm
> +then:
> + required:
> + - resets
> +
> +allOf:
> + - $ref: pwm.yaml#
Put the if under allOf:
allOf:
- $ref...
- if:
then:
This allows easier growth.
With above:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Best regards,
Krzysztof
