Hi Krzysztof Kozlowski, > Subject: Re: [PATCH v3 1/3] dt-bindings: arm: renesas: Document Renesas > RZ/V2M System Configuration > > On 15/11/2022 13:38, Biju Das wrote: > > From: Phil Edworthy <phil.edworthy@xxxxxxxxxxx> > > > > Add DT binding documentation for System Configuration (SYS) found on > > RZ/V2M SoC's. > > Thank you for your patch. There is something to discuss/improve. > > > +properties: > > + compatible: > > + const: renesas,r9a09g011-sys > > + > > + reg: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + sys: system-controller@a3f03000 { > > + compatible = "renesas,r9a09g011-sys"; > > + reg = <0xa3f03000 0x400>; > > Use 4 spaces for example indentation (two is also okay, but not three). Sure, will fix it to 2 spaces. Cheers, Biju > > With this fixed: > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > Best regards, > Krzysztof