Re: [PATCH v3 1/3] dt-bindings: arm: renesas: Document Renesas RZ/V2M System Configuration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 15/11/2022 13:38, Biju Das wrote:
> From: Phil Edworthy <phil.edworthy@xxxxxxxxxxx>
> 
> Add DT binding documentation for System Configuration (SYS) found on
> RZ/V2M SoC's.

Thank you for your patch. There is something to discuss/improve.

> +properties:
> +  compatible:
> +    const: renesas,r9a09g011-sys
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    sys: system-controller@a3f03000 {
> +       compatible = "renesas,r9a09g011-sys";
> +       reg = <0xa3f03000 0x400>;

Use 4 spaces for example indentation (two is also okay, but not three).

With this fixed:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux