Hi Philipp, Thanks for the feedback. > Subject: Re: [PATCH RFC 3/8] mfd: Add RZ/G2L MTU3 driver > > Hi Biju, > > On Mo, 2022-09-26 at 14:21 +0100, Biju Das wrote: > [...] > > +static int rzg2l_mtu3_probe(struct platform_device *pdev) { > > + struct reset_control *rstc; > > + struct rzg2l_mtu3 *ddata; > > + unsigned int i; > > + int ret; > > + > > + ddata = devm_kzalloc(&pdev->dev, sizeof(*ddata), GFP_KERNEL); > > + if (!ddata) > > + return -ENOMEM; > > + > > + ddata->mmio = devm_platform_ioremap_resource(pdev, 0); > > + if (IS_ERR(ddata->mmio)) > > + return PTR_ERR(ddata->mmio); > > + > > + rstc = devm_reset_control_get(&pdev->dev, NULL); > > Please use > > + rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL); > > instead. Agreed. Cheers, Biju