On 15/09/2022 23:26, Lad, Prabhakar wrote: > Hi Conor, > > Thank you for the review. > > On Thu, Sep 15, 2022 at 10:36 PM <Conor.Dooley@xxxxxxxxxxxxx> wrote: >> >> On 15/09/2022 19:15, Prabhakar wrote: >>> riscv: boot: dts: r9a07g043: Add placeholder nodes >> >> nit: s/boot// >> > Will fix that. > >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >>> >>> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> >>> >>> Add empty placeholder nodes to RZ/Five (R9A07G043) SoC DTSI. >> >> Can you explain why do you need placeholder nodes for this and >> cannot just directly include the other dtsis? >> > Since the RZ/G2UL SoC is ARM64 where it has a GIC and on RZ/Five SoC > we have PLIC for interrupts. Also the interrupt numbering for RZ/Five > SoC differs from RZ/G2UL SoC hence we are not directly using the > RZ/G2UL SoC DTSI [0]. > > [0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/renesas/r9a07g043.dtsi?h=v6.0-rc5 > > For the RZ/Five SMARC EVK I am re-using the below files [1] (SoM) and > [2] (Carrier board) as the RZ/Five SMARC EVK is pin compatible. Since > I am re-using these when trying to compile the RZ/Five DTB I get > compilation errors since the nodes dont exist (and there is no way > currently we can delete the node reference when the actual node itself > isn't present) hence these place holders. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/renesas/rzg2ul-smarc-som.dtsi?h=v6.0-rc5 > [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi?h=v6.0-rc5 If this method is acceptable to Geert, this explanation 100% needs to go into the commit message. Thanks, Conor.
