Re: [PATCH 3/4] arm64: dts: renesas: spider-cpu: Add MSIOF node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

> > +&msiof0 {
> > +       pinctrl-0 = <&msiof0_pins>;
> > +       pinctrl-names = "default";
> > +       status = "okay";
> > +};
> 
> I assume you added this becomes Spider has an MSIOF pin header?

Yes, that is one reason. It has it on the extension board. On the CPU
board, MSIOF0 is also connected to the CPLD.

> > +
> >  &pfc {
> >         pinctrl-0 = <&scif_clk_pins>;
> >         pinctrl-names = "default";
> > @@ -116,6 +122,12 @@ mmc_pins: mmc {
> >                 power-source = <1800>;
> >         };
> >
> > +       msiof0_pins: msiof0 {
> > +               groups = "msiof0_clk", "msiof0_sync", "msiof0_rxd",
> > +                        "msiof0_txd", "msiof0_ss1", "msiof0_ss2";
> 
> MSIOF0_SS2 is also used as the VDDQ18_33_SPI voltage selector, which
> is used as the power source for various components (but not available
> on the MSIOF0 pin header?), so I'm a but reluctant to add this patch...

Uh, you are right with the voltage selector. I missed that, sorry.
However, it is present on the MSIOF0 connector at pin 1. My suggestion
is to remove SS2 from the PFC node and add a comment describing the
situation?

All the best,

   Wolfram

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux