Hi Geert > > --- /dev/null > > +++ b/arch/arm64/boot/dts/renesas/r8a77980-es2-condor.dts > > I think this should be "r8a77980a-condor-i.dts" OK > > +#include "r8a77980-condor.dts" > > R-Car V3H2 is known to differ slightly from R-Car V3H. > Hence I suggest adding "r8a77980a.dtsi", which includes > "r8a77980.dtsi", and adds/removes/overrides what is different. OK, but because this is very 1st patch, it will be very simple and basic files. > I think this needs to override the compatible value, too: > 1. Based on previous discussions about how to handle R-Car V3H2, > "renesas,r8a77980a" should be added to the top-level compatible > value, so we can distinguish between R-Car V3H and V3H2. > All other compatible values can probably stay the same > (cfr. R-Car Gen3e), > 2. As the board is different, "renesas,condor-i" should be added, > 3. Depending on the differences between Condor and Condor-I, the > "reneas,condor" value should be dropped (or not). > > So I expect the override to become: > > compatible = "renesas,condor-i", "renesas,condor", > "renesas,r8a77980a", "renesas,r8a77980". > > or > > compatible = "renesas,condor-i", "renesas,r8a77980a", "renesas,r8a77980". 1st one looks good for me. Will do in v2 Thank you for your help !! Best regards --- Kuninori Morimoto
