Hi Prabhakar, On Mon, Aug 15, 2022 at 5:16 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote: > Introduce SOC_RENESAS_RZFIVE config option to enable Renesas RZ/Five > (R9A07G043) SoC, along side also add ARCH_RENESAS config option as most > of the Renesas drivers depend on this config option. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> Thanks for your patch! The technical part LGTM, so Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > --- a/arch/riscv/Kconfig.socs > +++ b/arch/riscv/Kconfig.socs > @@ -80,4 +80,18 @@ config SOC_CANAAN_K210_DTB_SOURCE > > endif # SOC_CANAAN > > +config ARCH_RENESAS We definitely want ARCH_RENESAS, as it serves as a gatekeeper for Kconfig options for IP cores found on Renesas ARM and RISC-V SoCs. > + bool > + select GPIOLIB > + select PINCTRL > + select SOC_BUS > + > +config SOC_RENESAS_RZFIVE Do we need this symbol? You could as well make ARCH_RENESAS above visible, and defer the actual SoC selection to ARCH_R9A07G043 in drivers/soc/renesas/Kconfig[1]. I don't know what is the policy on RISC-V. ARM64 has a "single-symbol in arch/arm64/Kconfig.platforms"-policy, so we handle SoC selection in drivers/soc/renesas/Kconfig, and that is fine, as it avoids merge conflicts. > + bool "Renesas RZ/Five SoC" > + select ARCH_R9A07G043 > + select ARCH_RENESAS > + select RESET_CONTROLLER > + help > + This enables support for Renesas RZ/Five SoC. > + > endmenu # "SoC selection" [1] https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-devel.git/commit/?h=renesas-drivers-for-v6.1&id=ebd0e06f3063cc2e3a689112904b29720579c6d2 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
