Hi Conor, Thank you for the review. On Tue, Jul 26, 2022 at 7:49 PM <Conor.Dooley@xxxxxxxxxxxxx> wrote: > > On 26/07/2022 19:06, Lad Prabhakar wrote: > > Introduce SOC_RENESAS_RZFIVE config option to enable Renesas RZ/Five > > (R9A07G043) SoC, along side also add ARCH_RENESAS config option as most > > of the Renesas drivers depend on this config option. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > --- > > arch/riscv/Kconfig.socs | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs > > index 69774bb362d6..91b7f38b77a8 100644 > > --- a/arch/riscv/Kconfig.socs > > +++ b/arch/riscv/Kconfig.socs > > @@ -80,4 +80,18 @@ config SOC_CANAAN_K210_DTB_SOURCE > > > > endif # SOC_CANAAN > > > > +config ARCH_RENESAS > > Hmm, I guess since it is very late in the day for v5.20 and there > appear to be some issues with the SOC_ symbol breaking the dts build > anyway, this is likely to be v5.21 content anyway... > I was targeting this for v5.21 ;) > ...but I would be wary of adding ARCH_ symbols from ARM archs prior > to figuring out what we actually want symbols in Kconfig.socs to > actually at LPC or w/e. Palmer? > > > + bool > > + select GPIOLIB > > + select PINCTRL > > + select SOC_BUS > > + > > +config SOC_RENESAS_RZFIVE > > I would like to see this added to the default defconfig so that > it has dtbs_check coverage by default. > Agreed, I will include it in the next version. Cheers, Prabhakar
