Hi Morimoto-san, On Fri, Jul 1, 2022 at 3:39 AM Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > This patch adds missing SCIF1_X. > Because Document (Rev.0.51) has 2xSCIF1 with no suffix (_A, _B), > this patch name it as _X. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> Thanks for your patch! > --- a/drivers/pinctrl/renesas/pfc-r8a779g0.c > +++ b/drivers/pinctrl/renesas/pfc-r8a779g0.c > @@ -2501,9 +2529,12 @@ static const struct sh_pfc_pin_group pinmux_groups[] = { > SH_PFC_PIN_GROUP(scif0_data), > SH_PFC_PIN_GROUP(scif0_clk), > SH_PFC_PIN_GROUP(scif0_ctrl), > - SH_PFC_PIN_GROUP(scif1_data), > - SH_PFC_PIN_GROUP(scif1_clk), > - SH_PFC_PIN_GROUP(scif1_ctrl), > + SH_PFC_PIN_GROUP(scif1_data), /* suffix might be updated */ > + SH_PFC_PIN_GROUP(scif1_data_x), /* suffix might be updated */ > + SH_PFC_PIN_GROUP(scif1_clk), /* suffix might be updated */ > + SH_PFC_PIN_GROUP(scif1_clk_x), /* suffix might be updated */ > + SH_PFC_PIN_GROUP(scif1_ctrl), /* suffix might be updated */ > + SH_PFC_PIN_GROUP(scif1_ctrl_x), /* suffix might be updated */ > SH_PFC_PIN_GROUP(scif3_data), /* suffix might be updated */ > SH_PFC_PIN_GROUP(scif3_data_a), /* suffix might be updated */ > SH_PFC_PIN_GROUP(scif3_clk), /* suffix might be updated */ > @@ -2786,9 +2817,13 @@ static const char * const scif0_groups[] = { > }; > > static const char * const scif1_groups[] = { > + /* suffix might be updated */ > "scif1_data", > + "scif1_data_x", > "scif1_clk", > + "scif1_clk_x", > "scif1_ctrl", > + "scif1_ctrl_x", > }; > > static const char * const scif3_groups[] = { I'll sort the above while applying (all *_x last). Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> i.e. will queue in renesas-pinctrl-for-v5.20. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds