Hi Morimoto-san, On Fri, Jul 1, 2022 at 3:39 AM Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > This patch adds missing HSCIF3_A > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> Thanks for your patch! > --- a/drivers/pinctrl/renesas/pfc-r8a779g0.c > +++ b/drivers/pinctrl/renesas/pfc-r8a779g0.c > @@ -2319,9 +2352,12 @@ static const struct sh_pfc_pin_group pinmux_groups[] = { > SH_PFC_PIN_GROUP(hscif2_data), > SH_PFC_PIN_GROUP(hscif2_clk), > SH_PFC_PIN_GROUP(hscif2_ctrl), > - SH_PFC_PIN_GROUP(hscif3_data), > - SH_PFC_PIN_GROUP(hscif3_clk), > - SH_PFC_PIN_GROUP(hscif3_ctrl), > + SH_PFC_PIN_GROUP(hscif3_data), /* suffix might be updated */ > + SH_PFC_PIN_GROUP(hscif3_data_a), /* suffix might be updated */ > + SH_PFC_PIN_GROUP(hscif3_clk), /* suffix might be updated */ > + SH_PFC_PIN_GROUP(hscif3_clk_a), /* suffix might be updated */ > + SH_PFC_PIN_GROUP(hscif3_ctrl), /* suffix might be updated */ > + SH_PFC_PIN_GROUP(hscif3_ctrl_a), /* suffix might be updated */ I'll sort the above while applying (all *_a last). > > SH_PFC_PIN_GROUP(i2c0), > SH_PFC_PIN_GROUP(i2c1), > @@ -2521,9 +2557,13 @@ static const char * const hscif2_groups[] = { > }; > > static const char * const hscif3_groups[] = { > + /* suffix might be updated */ > "hscif3_data", > + "hscif3_data_a", > "hscif3_clk", > + "hscif3_clk_a", > "hscif3_ctrl", > + "hscif3_ctrl_a", Likewise. > }; > > static const char * const i2c0_groups[] = { Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> i.e. will queue in renesas-pinctrl-for-v5.20. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds