Hi Morimoto-san, On Fri, Jul 1, 2022 at 3:39 AM Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > V4H has SCIF3 and SCIF3_A, but current PFC setting is mixed. > This patch cleanup SCIF3/SCIF3_A, based on Rev.0.51. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> Thanks for your patch! > --- a/drivers/pinctrl/renesas/pfc-r8a779g0.c > +++ b/drivers/pinctrl/renesas/pfc-r8a779g0.c > @@ -2476,9 +2504,12 @@ static const struct sh_pfc_pin_group pinmux_groups[] = { > SH_PFC_PIN_GROUP(scif1_data), > SH_PFC_PIN_GROUP(scif1_clk), > SH_PFC_PIN_GROUP(scif1_ctrl), > - SH_PFC_PIN_GROUP(scif3_data), > - SH_PFC_PIN_GROUP(scif3_clk), > - SH_PFC_PIN_GROUP(scif3_ctrl), > + SH_PFC_PIN_GROUP(scif3_data), /* suffix might be updated */ > + SH_PFC_PIN_GROUP(scif3_data_a), /* suffix might be updated */ > + SH_PFC_PIN_GROUP(scif3_clk), /* suffix might be updated */ > + SH_PFC_PIN_GROUP(scif3_clk_a), /* suffix might be updated */ > + SH_PFC_PIN_GROUP(scif3_ctrl), /* suffix might be updated */ > + SH_PFC_PIN_GROUP(scif3_ctrl_a), /* suffix might be updated */ > SH_PFC_PIN_GROUP(scif4_data), > SH_PFC_PIN_GROUP(scif4_clk), > SH_PFC_PIN_GROUP(scif4_ctrl), > @@ -2761,9 +2792,13 @@ static const char * const scif1_groups[] = { > }; > > static const char * const scif3_groups[] = { > + /* suffix might be updated */ > "scif3_data", > + "scif3_data_a", > "scif3_clk", > + "scif3_clk_a", > "scif3_ctrl", > + "scif3_ctrl_a", > }; > > static const char * const scif4_groups[] = { I'll sort the above while applying (all *_a last). Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> i.e. will queue in renesas-pinctrl-for-v5.20. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds