Hi Morimoto-san,
On Fri, Jul 1, 2022 at 3:39 AM Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
>
> This patch adds missing HSCIF1.
> Because Document (Rev.0.51) has 2xHSCIF1 with no suffix (_A, _B),
> this patch name it as _X.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
Thanks for your patch!
> --- a/drivers/pinctrl/renesas/pfc-r8a779g0.c
> +++ b/drivers/pinctrl/renesas/pfc-r8a779g0.c
> @@ -2346,9 +2376,12 @@ static const struct sh_pfc_pin_group pinmux_groups[] = {
> SH_PFC_PIN_GROUP(hscif0_data),
> SH_PFC_PIN_GROUP(hscif0_clk),
> SH_PFC_PIN_GROUP(hscif0_ctrl),
> - SH_PFC_PIN_GROUP(hscif1_data),
> - SH_PFC_PIN_GROUP(hscif1_clk),
> - SH_PFC_PIN_GROUP(hscif1_ctrl),
> + SH_PFC_PIN_GROUP(hscif1_data), /* suffix might be updated */
> + SH_PFC_PIN_GROUP(hscif1_data_x), /* suffix might be updated */
> + SH_PFC_PIN_GROUP(hscif1_clk), /* suffix might be updated */
> + SH_PFC_PIN_GROUP(hscif1_clk_x), /* suffix might be updated */
> + SH_PFC_PIN_GROUP(hscif1_ctrl), /* suffix might be updated */
> + SH_PFC_PIN_GROUP(hscif1_ctrl_x), /* suffix might be updated */
> SH_PFC_PIN_GROUP(hscif2_data),
> SH_PFC_PIN_GROUP(hscif2_clk),
> SH_PFC_PIN_GROUP(hscif2_ctrl),
> @@ -2545,9 +2578,13 @@ static const char * const hscif0_groups[] = {
> };
>
> static const char * const hscif1_groups[] = {
> + /* suffix might be updated */
> "hscif1_data",
> + "hscif1_data_x",
> "hscif1_clk",
> + "hscif1_clk_x",
> "hscif1_ctrl",
> + "hscif1_ctrl_x",
> };
I'll sort the above (all *_x last) while applying.
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
i.e. will queue in renesas-pinctrl-for-v5.20.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
