Hi Geert > > > These are definitely still wrong, and not fixed by any of your > > > subsequent patches: to enable I2C0 functionality, the corresponding > > > SEL_{SCL,SDA}0 bit should be set to 1, not 0. > > > Same for I2C[1-5] below. > > > > There was such patch, and this patch series merged it. > > I don't see such a patch in this series? > > > Now I'm asking why the patch was needed. > > Sorry, I don't understand. Sorry for un-clear explaination. [03/21] and [04/21] merged some/many BSP original patches into one. [03/21] is including I2C fixup patch from Kihara-san which fixup the SEL_{SCL,SDA} value from 1 to 0, but this fixup seems strange, and you are now pointing it. I'm not sure why this patch was needed, now, I'm asking. https://github.com/renesas-rcar/linux-bsp/commit/2155127dacd61a4bb2f6f316f716a9338799a786 Thank you for your help !! Best regards --- Kuninori Morimoto