Hi Geert Thank you for review. > > + /* IP0SR8 */ > > + PINMUX_IPSR_MSEL(IP0SR8_3_0, SCL0, SEL_SCL0_0), > > + PINMUX_IPSR_MSEL(IP0SR8_7_4, SDA0, SEL_SDA0_0), > > These are definitely still wrong, and not fixed by any of your > subsequent patches: to enable I2C0 functionality, the corresponding > SEL_{SCL,SDA}0 bit should be set to 1, not 0. > Same for I2C[1-5] below. There was such patch, and this patch series merged it. Now I'm asking why the patch was needed. I will fix and re-post v4. But, 1 things. As I mentioned before, I want to keep original patch as much as possible, even though it has bug (missing pins, having unnecessary settings). In other words, the difference from original patch is only cleanup:ed. I will keep current style on v4, too. About suffix, I'm asking it to Doc team. Thank you for your help !! Best regards --- Kuninori Morimoto