Hi Geert-san,
Thank you for your review!
> From: Geert Uytterhoeven, Sent: Wednesday, June 15, 2022 5:49 PM
>
> Hi Shimoda-san,
>
> On Mon, Jun 13, 2022 at 1:57 PM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> > Document bindings for Renesas R-Car Gen4 and R-Car S4-8 (R8A779F0)
> > PCIe host module.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml
> > @@ -0,0 +1,104 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +# Copyright (C) 2022 Renesas Electronics Corp.
> > +%YAML 1.2
> > +---
<snip>
> > +title: Renesas R-Car Gen4 PCIe Host
> > +
> > +maintainers:
> > + - Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > +
> > +allOf:
> > + - $ref: snps,dw-pcie.yaml#
> > +
> > +properties:
> > + compatible:
> > + items:
> > + - const: renesas,r8a779f0-pcie # R-Car S4-8
> > + - const: renesas,rcar-gen4-pcie # R-Car Gen4
> > + - const: snps,dw-pcie
> > +
> > + interrupts:
> > + maxItems: 6
>
> The R-Car S4 INTC Interrupt Mapping spreadsheet says there are 7.
>
> items:
> - description: Other Errors
> - description: DMA Event
> - description: Correctable Error
> - description: Fatal Error
> - description: Non-Fatal Error
> - description: Reception of a ERR message from link partner
> - description: Reception of Vendor
>
> > + interrupt-names:
> > + items:
> > + - const: msi
I think this should be "other" instead of msi.
> Missing:
>
> - const: dma
You're correct. I'll fix it.
> > + - const: err
>
> correctable?
I think so. I'll fix it.
Best regards,
Yoshihiro Shimoda
> > + - const: fatal
> > + - const: nonfatal
> > + - const: lp
> > + - const: vndmsg
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
