RE: [PATCH v2 1/2] arm64: dts: renesas: r8a779f0: Add IPMMU nodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert-san,

> From: Geert Uytterhoeven, Sent: Wednesday, June 15, 2022 7:04 PM
> 
> Hi Shimoda-san,
> 
> On Mon, May 30, 2022 at 4:46 AM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> > Add IPMMU nodes for r8a779f0.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/renesas/r8a779f0.dtsi | 46 +++++++++++++++++++++++
> >  1 file changed, 46 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
> > index df46fb87cffc..512e0b57fd6a 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
> > @@ -343,6 +343,52 @@ dmac1: dma-controller@e7351000 {
> >                         dma-channels = <16>;
> >                 };
> >
> > +               ipmmu_rt0: iommu@ee480000 {
> > +                       compatible = "renesas,ipmmu-r8a779f0",
> > +                                    "renesas,rcar-gen4-ipmmu";
> 
> "renesas,rcar-gen4-ipmmu-vmsa"
> 
> I thought I had fixed that while applying, but that was for r8a779a0.
> Will fix for good.

Thank you for pointing it out. I realized the drivers/iommu/ipmmu-vmsa.c
also mistook about the compatible string...
-----
        }, {
                .compatible = "renesas,rcar-gen4-ipmmu",
                .data = &ipmmu_features_rcar_gen4,
        }, { 
-----

So, I'll fix the driver and dtsi file tomorrow.

Best regards,
Yoshihiro Shimoda

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux