Re: [PATCH 2/3] clk: renesas: r9a06g032: drop some unused fields

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ralph,

On Wed, May 18, 2022 at 7:28 PM Ralph Siemsen <ralph.siemsen@xxxxxxxxxx> wrote:
> Minor cleanup, remove unused fields from struct r9a06g032_clkdesc.
>
> Signed-off-by: Ralph Siemsen <ralph.siemsen@xxxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
i.e. will queue in renesas-clk-for-v5.20.

> --- a/drivers/clk/renesas/r9a06g032-clocks.c
> +++ b/drivers/clk/renesas/r9a06g032-clocks.c
> @@ -84,7 +82,7 @@ struct r9a06g032_clkdesc {
>  #define D_UGATE(_idx, _n, _src, _g, _gi, _g1, _r1, _g2, _r2) \
>         { .type = K_DUALGATE, .index = R9A06G032_##_idx, \
>                 .source = 1 + R9A06G032_##_src, .name = _n, \
> -               .dual = { .group = _g, .index = _gi, \
> +               .dual = { .group = _g, \

My first reaction was: this makes _gi unused.
Then I noticed you handle that in your next patch.
I'll merge them into a single commit while applying.

>                         .g1 = _g1, .r1 = _r1, .g2 = _g2, .r2 = _r2 }, }
>
>  enum { K_GATE = 0, K_FFC, K_DIV, K_BITSEL, K_DUALGATE };

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux