On Wed, May 18, 2022 at 3:08 PM Geert Uytterhoeven
<geert+renesas@xxxxxxxxx> wrote:
Thanks for your patches!
> Commit 6c846d026d49 ("gpio: Don't fiddle with irqchips marked as
> immutable") added a warning to indicate if the gpiolib is altering the
> internals of irqchips. Following this change the following warning is
> now observed for the pca953x driver:
>
> gpio gpiochip7: (0-0020): not an immutable chip, please consider fixing it!
>
> Fix this by making the irqchip in the pca953x driver immutable.
I have two fixes against documentation [1] and here is exactly the
point to do it better.
Please, update all your patches accordingly.
[1]: In one of the recent Linux Nexts:
e9fdcc2d8376 Documentation: gpio: Advertise irqd_to_hwirq() helper in
the examples
bdb6528ec550 Documentation: gpio: Fix IRQ mask and unmask examples
...
> irq_hw_number_t hwirq = irqd_to_hwirq(d);
>
> + gpiochip_enable_irq(gc, d->hwirq);
We have already hwirq.
--
With Best Regards,
Andy Shevchenko
