Hi Phil, On Tue, May 3, 2022 at 2:02 PM Phil Edworthy <phil.edworthy@xxxxxxxxxxx> wrote: > Add basic support for RZ/V2M EVK (based on R9A09G011): > - memory > - External input clock > - UART > > Signed-off-by: Phil Edworthy <phil.edworthy@xxxxxxxxxxx> > Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > --- > v3: > - Add comment about mem reserved for ISP Firmware > - Remove sys node Thanks for the update! > --- /dev/null > +++ b/arch/arm64/boot/dts/renesas/r9a09g011-v2mevk2.dts > @@ -0,0 +1,44 @@ > +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +/* > + * Device Tree Source for the RZ/V2M (r9a09g011) Evaluation Kit Board > + * > + * Copyright (C) 2022 Renesas Electronics Corp. > + */ > + > +/dts-v1/; > +#include "r9a09g011.dtsi" > + > +/ { > + memory@58000000 { > + device_type = "memory"; > + /* > + * first 2GiB is reserved for ISP Firmware, "2GiB" (0x80000000) doesn't look right to me. Perhaps 1.25 GIB? If you confirm, I can fix up (and the previous patch), and queue in renesas-devel for v5.19. > + * next 128MiB is reserved for secure area. > + */ > + reg = <0x0 0x58000000 0x0 0x28000000>; > + }; The rest LGTM, so with the above fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds