Re: [PATCH v3 1/2] arm64: dts: renesas: r9a07g044: Fix external clk node names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Biju,

On Thu, Apr 28, 2022 at 3:03 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > Subject: Re: [PATCH v3 1/2] arm64: dts: renesas: r9a07g044: Fix external
> > clk node names
> > On Tue, Apr 26, 2022 at 8:40 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > wrote:
> > > Add suffix '-clk' for can and extal clk node names and replace the clk
> > > node names audio_clk{1,2} with clk-{1,2} as per the device tree
> > > specification.
> > >
> > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>

> > >                 compatible = "fixed-clock";
> > >                 #clock-cells = <0>;
> > >                 /* This value must be overridden by boards that provide
> > it */
> > >                 clock-frequency = <0>;
> > >         };
> > >
> > > -       /* External CAN clock - to be overridden by boards that provide
> > it */
> > > -       can_clk: can {
> > > +       audio_clk2: clk-2 {
> >
> > audio_clk2: audio-2clk?
>
> OK, you mean like audio_clk1, "audio_clk2: audio2-clk"
> as "2clk" is not generic name for clk?

Oops, indeed.
Sorry, my review fingers are becoming overloaded ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux