Hi Biju,
On Tue, Apr 26, 2022 at 8:40 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> Add suffix '-clk' for can and extal clk node names and replace the
> clk node names audio_clk{1,2} with clk-{1,2} as per the device
> tree specification.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> ---
> v2->v3:
> * Sorted clk node-names alphabetically
> v1->v2:
> * Replaced clk node names audio_clk{1,2} with clk-{1,2}.
Thanks for the update!
> --- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> @@ -13,29 +13,29 @@ / {
> #address-cells = <2>;
> #size-cells = <2>;
>
> - audio_clk1: audio_clk1 {
> + /* External CAN clock - to be overridden by boards that provide it */
> + can_clk: can-clk {
OK.
> compatible = "fixed-clock";
> #clock-cells = <0>;
> - /* This value must be overridden by boards that provide it */
> clock-frequency = <0>;
> };
>
> - audio_clk2: audio_clk2 {
> + audio_clk1: clk-1 {
"clk-1" has a high risk of conflicts. "audio_clk1: audio1-clk"?
> compatible = "fixed-clock";
> #clock-cells = <0>;
> /* This value must be overridden by boards that provide it */
> clock-frequency = <0>;
> };
>
> - /* External CAN clock - to be overridden by boards that provide it */
> - can_clk: can {
> + audio_clk2: clk-2 {
audio_clk2: audio-2clk?
> compatible = "fixed-clock";
> #clock-cells = <0>;
> + /* This value must be overridden by boards that provide it */
> clock-frequency = <0>;
> };
>
> /* clock can be either from exclk or crystal oscillator (XIN/XOUT) */
> - extal_clk: extal {
> + extal_clk: extal-clk {
OK
> compatible = "fixed-clock";
> #clock-cells = <0>;
> /* This value must be overridden by the board */
Same comments for patch 2/2.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
