Re: [PATCH v9 5/9] dmaengine: dw: dmamux: Introduce RZN1 DMA router support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andy,

andriy.shevchenko@xxxxxxxxxxxxxxx wrote on Tue, 12 Apr 2022 14:08:33
+0300:

> On Tue, Apr 12, 2022 at 02:06:31PM +0300, Andy Shevchenko wrote:
> > On Tue, Apr 12, 2022 at 12:21:34PM +0200, Miquel Raynal wrote:  
> 
> ...
> 
> > > +	clear_bit(BIT(map->req_idx), dmamux->used_chans);  
> 
> On top of the previously asked, are you sure the use of BIT() is correct here?

Looks like I have been tricked by the doc...

	* DOC: bitmap bitops
	*  set_bit(bit, addr)                  *addr |= bit
	*  clear_bit(bit, addr)                *addr &= ~bit



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux