On Mon, Apr 11, 2022 at 02:55:29PM +0200, Geert Uytterhoeven wrote: > For manual write and read, factor out the common access to the first > data register by keeping track of the current data pointer. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Works fine with reading/writing on a V3U, so: Tested-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> I agree the code is more concise. I am not sure, though, if it is really more readable. But I don't mind very much, so except for a small nit: Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > + if (nbytes == 8) > + regmap_write(rpc->regmap, RPCIF_SMWDR1, *p++); > + regmap_write(rpc->regmap, RPCIF_SMWDR0, *p++); Last '++' can be omitted?
Attachment:
signature.asc
Description: PGP signature
