On 17/03/2022 12:55, Lad, Prabhakar wrote: > Hi Krzysztof, > > Thank you for the review. > > On Thu, Mar 17, 2022 at 9:44 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: >> >> On 17/03/2022 02:24, Lad Prabhakar wrote: >>> Add DT bindings for the Renesas RZ/G2L Interrupt Controller. >>> >>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> >>> --- >>> .../renesas,rzg2l-irqc.yaml | 131 ++++++++++++++++++ >>> 1 file changed, 131 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml >>> new file mode 100644 >>> index 000000000000..a14492ec9235 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml >>> @@ -0,0 +1,131 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/interrupt-controller/renesas,rzg2l-irqc.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Renesas RZ/G2L (and alike SoC's) Interrupt Controller (IA55) >>> + >>> +maintainers: >>> + - Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> >>> + - Geert Uytterhoeven <geert+renesas@xxxxxxxxx> >>> + >>> +description: | >>> + IA55 performs various interrupt controls including synchronization for the external >>> + interrupts of NMI, IRQ, and GPIOINT and the interrupts of the built-in peripheral >>> + interrupts output by each IP. And it notifies the interrupt to the GIC >>> + - IRQ sense select for 8 external interrupts, mapped to 8 GIC SPI interrupts >>> + - GPIO pins used as external interrupt input pins, mapped to 32 GIC SPI interrupts >>> + - NMI edge select (NMI is not treated as NMI exception and supports fall edge and >>> + stand-up edge detection interrupts) >>> + >>> +allOf: >>> + - $ref: /schemas/interrupt-controller.yaml# >>> + >>> +properties: >>> + compatible: >>> + items: >>> + - enum: >>> + - renesas,r9a07g044-irqc # RZ/G2L >>> + - const: renesas,rzg2l-irqc >>> + >>> + '#interrupt-cells': >>> + const: 2 >>> + >>> + '#address-cells': >>> + const: 0 >>> + >>> + interrupt-controller: true >>> + >>> + reg: >>> + maxItems: 1> + >>> + interrupts: >>> + maxItems: 41 >>> + >>> + clocks: >>> + maxItems: 2 >>> + >>> + clock-names: >>> + items: >>> + - const: clk >>> + - const: pclk >>> + >>> + power-domains: >>> + maxItems: 1 >>> + >>> + resets: >>> + maxItems: 1 >>> + >>> +required: >>> + - compatible >>> + - '#interrupt-cells' >>> + - '#address-cells' >>> + - interrupt-controller >>> + - reg >>> + - interrupts >>> + - clocks >>> + - clock-names >>> + - power-domains >>> + - resets >>> + >>> +additionalProperties: false >> >> This should be rather unevaluatedProperties and remove >> interrupt-controller:true from properties. >> > Ok will do. After some tests it seems interrupt-controller:true is required in properties, so only change unevaluatedProperties. Best regards, Krzysztof
