Hi Geert-san, Thank you for the patch! > From: Geert Uytterhoeven, Sent: Tuesday, February 22, 2022 12:44 AM > > Add initial Pin Function Controller (PFC) support for the Renesas R-Car > S4-8 (R8A779F0) SoC, including bias, drive strength and voltage control. > > Based on a larger patch in the BSP by LUU HOAI. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> <snip> > diff --git a/drivers/pinctrl/renesas/pfc-r8a779f0.c b/drivers/pinctrl/renesas/pfc-r8a779f0.c > new file mode 100644 > index 0000000000000000..2f3fbb794eb635c1 > --- /dev/null > +++ b/drivers/pinctrl/renesas/pfc-r8a779f0.c > @@ -0,0 +1,1024 @@ <snip> > +static const struct pinmux_ioctrl_reg pinmux_ioctrl_regs[] = { > + [POC0] = { 0xe60500a0, }, > + [POC1] = { 0xe60508a0, }, > + [POC2] = { 0xe60510a0, }, > + [POC3] = { 0xe60518a0, }, > + [TD0SEL1] = { 0xe6058120, }, TD0SEL1 should be 0xe6050920 (0xe6050800 + 0x120). After fixed it, Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> Best regards, Yoshihiro Shimoda