Re: [PATCH v2 2/2] sh_eth: sh_eth_close() always returns 0

[Sergei Shtylyov <sergei.shtylyov@xxxxxxxxx>]

On 01.02.2022 11:58, Geert Uytterhoeven wrote:

[...]
> > sh_eth_close() always returns 0, hence the check in sh_eth_wol_restore()
> > is pointless (however we cannot change the prototype of sh_eth_close() as
> > it implements the driver's ndo_stop() method).
> >
> > Found by Linux Verification Center (linuxtesting.org) with the SVACE static
> > analysis tool.
> >
> > Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxx>
>
> Thanks for your patch!
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> Note that there's a second call in sh_eth_suspend().

  Made no sense to change it. :-)

> Gr{oetje,eeting}s,
>
>                          Geert

MBR, Sergey