Re: [PATCH v2 2/2] sh_eth: sh_eth_close() always returns 0

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Sergei,

On Tue, Feb 1, 2022 at 3:00 AM Sergey Shtylyov <s.shtylyov@xxxxxx> wrote:
> sh_eth_close() always returns 0, hence the check in sh_eth_wol_restore()
> is pointless (however we cannot change the prototype of sh_eth_close() as
> it implements the driver's ndo_stop() method).
>
> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
> analysis tool.
>
> Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxx>

Thanks for your patch!

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Note that there's a second call in sh_eth_suspend().

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds