Hi Prabhakar,
On Fri, Jan 21, 2022 at 2:41 AM Lad Prabhakar
<prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote:
> From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
>
> As per RZ/G2L HW manual (Rev.1.00 Sep, 2021) DEV_ID [31:28] indicates
> product revision. Use this information to populate the revision info
> for RZ/G2L family.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> ---
> v1->v2
> * Fixed freeing up soc_dev_attr in error path.
Thanks for the update!
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
i.e. will queue in renesas-devel for v5.18.
> --- a/drivers/soc/renesas/renesas-soc.c
> +++ b/drivers/soc/renesas/renesas-soc.c
> @@ -405,41 +417,38 @@ static int __init renesas_soc_init(void)
>
> eshi = ((product >> 4) & 0x0f) + 1;
> eslo = product & 0xf;
> + soc_dev_attr->revision = kasprintf(GFP_KERNEL, "ES%u.%u",
> + eshi, eslo);
> + } else if (id == &id_rzg2l) {
> + eshi = ((product >> 28) & 0x0f);
> + soc_dev_attr->revision = kasprintf(GFP_KERNEL, "Rev %u",
> + eshi);
Would you mind if I would drop the "Rev " while applying?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
