Hi Laurent,
On Mon, Jan 10, 2022 at 12:24 PM Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
> On Mon, Jan 10, 2022 at 11:10:59AM +0100, Geert Uytterhoeven wrote:
> > On Wed, Dec 29, 2021 at 8:18 PM Laurent Pinchart wrote:
> > > Endpoints node must have a remote-endpoint property, as endpoints only
> > > exist to model a link between ports. Drop the empty lvds endpoints from
> > > SoC dtsi files, then should be instead declared in the board dts or in
> > > overlays.
> > >
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> >
> > Thanks for your patch!
> > I'm interested in hearing Rob's opinion about the general idea...
>
> Me too :-)
>
> > > ---
> > > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 2 --
> > > arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 2 --
> > > arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 4 ----
> > > arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 2 --
> > > arch/arm64/boot/dts/renesas/r8a77951.dtsi | 2 --
> > > arch/arm64/boot/dts/renesas/r8a77960.dtsi | 2 --
> > > arch/arm64/boot/dts/renesas/r8a77965.dtsi | 2 --
> > > arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 --
> > > arch/arm64/boot/dts/renesas/r8a77980.dtsi | 2 --
> > > arch/arm64/boot/dts/renesas/r8a77990.dtsi | 4 ----
> > > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 4 ----
> > > 11 files changed, 28 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > > index 6f4fffacfca2..9a8c1bd923af 100644
> > > --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > > @@ -2771,8 +2771,6 @@ lvds0_in: endpoint {
> > > };
> > > port@1 {
> > > reg = <1>;
> > > - lvds0_out: endpoint {
> > > - };
> >
> > As there are several DTS files that refer to this label, this change
> > will break them?
>
> While files are you referring to ?
The various board files.
Seems like I was slightly misled by your fake prerequisites.
Upon closer inspection, the board files do not rely on the labels in
the SoC .dtsi files, but (re)define their own, matching the former.
So everything is fine.
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > > base-commit: 2b534e90a1e31c7fc9536b512b72274cc3575f4c
> >
> > Why does this depend on a commit in drm-next?
> > DTS changes are supposed to go in through renesas-devel and soc.
>
> Because it happens to have been developed there, that's all. There's no
> specific reason.
>
> > > prerequisite-patch-id: 98434eb22c020924bc338316e54a7b42ea339e9f
> > > prerequisite-patch-id: ce261c9865255051f2c2107a930b0f15ce862703
> > > prerequisite-patch-id: 500ab746415c5421e41128c2b0db35987d8d7a49
> > > prerequisite-patch-id: ad2d5ad025f9cfa0dc453d7e0b2aa96b4514afd7
> > > prerequisite-patch-id: ac76bcc0f7b278863e362db083a7d64bbd0bd030
> > > prerequisite-patch-id: c7a7c3a6b9dbbae18a768160db70d7010ea71ca5
> >
> > While Google does not index by commit ID or patch ID, at least the
> > base-commit can be found easily in linux-next. But even with some
> > scripting, the prerequisites cannot. What are these prerequisites?
> > Do you have lore links?
>
> Probably something completely unrelated that I had in my tree when
> generating the series. You can likely ignore that, sorry for the noise.
OK.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
