Hi Shimoda-san,
On Wed, Dec 22, 2021 at 11:08 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> > From: Geert Uytterhoeven, Sent: Wednesday, December 22, 2021 6:17 PM
> > As some registers do not exist (or are not documented) on R-Car S4-8, perhaps you want to document that in the comments
> > for the register definitions, too? Fortunately none of them are used by the driver.
>
> You're correct. So, I'll modify the following code:
>
> -#define RCAR_DMACHCLR 0x0080 /* Not on R-Car V3U */
> +#define RCAR_DMACHCLR 0x0080 /* Not on R-Car Gen4 */
> (sorry these tabs are replaced as spaces)
>
> Also, I'll add such information in the commit description
> like below.
> -----
> Add support for R-Car S4-8. We can reuse R-Car V3U code so that
> renames variable names as "gen4".
>
> Note that some registers of R-Car V3U do not exist on R-Car S4-8,
> but none of them are used by the driver for now.
> -----
>
> Are they acceptable?
Perfect! Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
