RE: [PATCH 2/3] dmaengine: rcar-dmac: Add support for R-Car S4-8

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert-san,

Thank you for your review!

> From: Geert Uytterhoeven, Sent: Wednesday, December 22, 2021 6:17 PM
> 
> Hi Shimoda-san,
> 
> On Tue, Dec 21, 2021 at 10:50 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> > Add support for R-Car S4-8. We can reuse R-Car V3U code so that
> > renames variable names as "gen4".
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> 
> Thanks for your patch!
> 
> Perhaps you want to rename RCAR_V3U_DMACHCLR, too?

Yes, I should have to rename it, too. I'll fix it on v2.

> As some registers do not exist (or are not documented) on R-Car S4-8, perhaps you want to document that in the comments
> for the register definitions, too? Fortunately none of them are used by the driver.

You're correct. So, I'll modify the following code:	

-#define RCAR_DMACHCLR                   0x0080  /* Not on R-Car V3U */
+#define RCAR_DMACHCLR                   0x0080  /* Not on R-Car Gen4 */
(sorry these tabs are replaced as spaces)

Also, I'll add such information in the commit description
like below.
-----
Add support for R-Car S4-8. We can reuse R-Car V3U code so that
renames variable names as "gen4".

Note that some registers of R-Car V3U do not exist on R-Car S4-8,
but none of them are used by the driver for now.
-----

Are they acceptable?

> As this patch is correct:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Thanks!

Best regards,
Yoshihiro Shimoda





[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux