RE: [PATCH v5 0/2] Add WDT driver for RZ/G2L

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Subject: Re: [PATCH v5 0/2] Add WDT driver for RZ/G2L
> 
> On 12/7/21 8:07 AM, Biju Das wrote:
> > Hi All,
> >
> > Gentle ping.
> >
> > Are we happy with this patch series? Please let me know.
> >
> 
> I think so. You retained my Reviewed-by: tag, so I did not see a need to
> reply (again).

Thank you.

Cheers,
Biju

> >
> >
> >> Subject: [PATCH v5 0/2] Add WDT driver for RZ/G2L
> >>
> >> This patch series aims to add WDT driver support for RZ/G2L SoC's.
> >>
> >> WDT has 3 channels
> >> 1) CH0 to check the operation of Cortex-A55-CPU Core0
> >> 2) CH1 to check the operation of Cortex-A55-CPU Core1
> >> 3) CH2 to check the operation of Cortex-M33 CPU
> >>
> >> WDT IP supports
> >> 1) Normal Watchdog Timer Function
> >> 2) Reset Request Function due to CPU Parity Error
> >>
> >> Once the software activates the watchdog timer, the watchdog timer
> >> does not stop until it is reset.
> >>
> >> Current driver supports Normal Watchdog Timer basic functionality.
> >>
> >> Tested WDT driver with selftests tool and reboot command
> >>
> >> All 3 channels tested with below command.
> >>
> >> cat /dev/watchdog  & for i in {1..60}; do sleep 1; echo $i; devmem2
> >> 0x12800808; done cat /dev/watchdog1  & for i in {1..60}; do sleep 1;
> >> echo $i; devmem2 0x12800c08; done cat /dev/watchdog2 & for i in
> >> {1..60}; do sleep 1; echo $i; devmem2 0x12800408; done
> >>
> >> v4->v5:
> >>   * Started using the macros MICRO and USEC_PER_SEC
> >>   * Renamed rzg2l_wdt_get_cycle_msec() to rzg2l_wdt_get_cycle_usec()
> >>   * Fixed the value of priv->wdev.max_timeout in seconds.
> >> V3->V4:
> >>   * Fixed the build issue reported by kernel test robot
> >> V2->V3:
> >>   * Added Rb tag from Guenter Roeck
> >>   * Removed Removed patch#1, as the clock changes related to WDT
> >> reset selection
> >>     will be handled in TF-A.
> >> V1->V2:
> >>   * started using clk_get/put instead of devm_clk_get/put
> >>   * Moved devm_add_action_or_reset after set_drvdata() and
> >>   * removed redundant action on devm_add_action_or_reset() failure.
> >> RFC->V1
> >>   * Removed patch#3, the clk patch is queued for 5.17
> >>   * Added clock-names and interrupt-names as required properties for
> RZ/G2L
> >>   * Re-order clocknames with internal module clock first
> >>   * Removed pclk_rate from priv.
> >>   * rzg2l_wdt_write() returns void and Removed tiemout related to
> >> register update
> >>   * rzg2l_wdt_init_timeout() returns void and removed delays.
> >>   * removed set_bit(WDOG_HW_RUNNING,..) as we can stop watchdog
> >>   * renamed reset_assert_clock_disable->reset_assert_pm_disable_put
> >>   * started using devm_reset_control_get_exclusive()
> >>   * removed platform_set_drvdata(pdev, priv) as there is no user
> >>   * removed watchdog_set_restart_priority(&priv->wdev, 0) as 0 is the
> >> default.
> >>   * removed remove callback as it is empty.
> >>
> >> Biju Das (2):
> >>    dt-bindings: watchdog: renesas,wdt: Add support for RZ/G2L
> >>    watchdog: Add Watchdog Timer driver for RZ/G2L
> >>
> >>   .../bindings/watchdog/renesas,wdt.yaml        |  75 +++--
> >>   drivers/watchdog/Kconfig                      |   8 +
> >>   drivers/watchdog/Makefile                     |   1 +
> >>   drivers/watchdog/rzg2l_wdt.c                  | 263
> ++++++++++++++++++
> >>   4 files changed, 329 insertions(+), 18 deletions(-)  create mode
> >> 100644 drivers/watchdog/rzg2l_wdt.c
> >>
> >> --
> >> 2.17.1
> >





[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux