Hi Sergey, > Subject: Re: [PATCH 00/14] Add functional support for Gigabit Ethernet > driver > > On 10/9/21 10:07 PM, Biju Das wrote: > > > The DMAC and EMAC blocks of Gigabit Ethernet IP found on RZ/G2L SoC > > are similar to the R-Car Ethernet AVB IP. > > > > The Gigabit Ethernet IP consists of Ethernet controller (E-MAC), > > Internal TCP/IP Offload Engine (TOE) and Dedicated Direct memory > > access controller (DMAC). > > > > With a few changes in the driver we can support both IPs. > > > > This patch series is aims to add functional support for Gigabit > > Ethernet driver by filling all the stubs except set_features. > > > > set_feature patch will send as separate RFC patch along with > > rx_checksum patch, as it needs detailed discussion related to HW > checksum. > > > > Ref:- > > > > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc > > hwork.kernel.org%2Fproject%2Flinux-renesas-soc%2Flist%2F%3Fseries%3D55 > > 7655&data=04%7C01%7Cbiju.das.jz%40bp.renesas.com%7C25bc7b9155d8402 > > a191808d98b5ae62f%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C6376940 > > 44814904836%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMz > > IiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Vktj5v0GvrNf%2BDNIFs > > e6xjCUm6OjtzwHvK3q8aG1E5Y%3D&reserved=0 > > > > RFC->V1: > > * Removed patch#3 will send it as RFC > > * Removed rx_csum functionality from patch#7, will send it as RFC > > * Renamed "nc_queue" -> "nc_queues" > > * Separated the comment patch into 2 separate patches. > > * Documented PFRI register bit > > * Added Sergy's Rb tag > > It's Sergey. :-) My Bad. Sorry will taken care this in future. I need to send V2, as accidentally I have added 2 macros in patch #6 As part of RFC discussion into v1. I will send V2 to remove this. Regards, Biju > > > RFC changes: > > * used ALIGN macro for calculating the value for max_rx_len. > > * used rx_max_buf_size instead of rx_2k_buffers feature bit. > > * moved struct ravb_rx_desc *gbeth_rx_ring near to > ravb_private::rx_ring > > and allocating it for 1 RX queue. > > * Started using gbeth_rx_ring instead of gbeth_rx_ring[q]. > > * renamed ravb_alloc_rx_desc to ravb_alloc_rx_desc_rcar > > * renamed ravb_rx_ring_free to ravb_rx_ring_free_rcar > > * renamed ravb_rx_ring_format to ravb_rx_ring_format_rcar > > * renamed ravb_rcar_rx to ravb_rx_rcar > > * renamed "tsrq" variable > > * Updated the comments > > > > Biju Das (14): > > ravb: Use ALIGN macro for max_rx_len > > ravb: Add rx_max_buf_size to struct ravb_hw_info > > ravb: Fillup ravb_alloc_rx_desc_gbeth() stub > > ravb: Fillup ravb_rx_ring_free_gbeth() stub > > ravb: Fillup ravb_rx_ring_format_gbeth() stub > > ravb: Fillup ravb_rx_gbeth() stub > > ravb: Add carrier_counters to struct ravb_hw_info > > ravb: Add support to retrieve stats for GbEthernet > > ravb: Rename "tsrq" variable > > ravb: Optimize ravb_emac_init_gbeth function > > ravb: Rename "nc_queue" feature bit > > ravb: Document PFRI register bit > > ravb: Update EMAC configuration mode comment > > ravb: Fix typo AVB->DMAC > > > > drivers/net/ethernet/renesas/ravb.h | 17 +- > > drivers/net/ethernet/renesas/ravb_main.c | 325 > > +++++++++++++++++++---- > > 2 files changed, 291 insertions(+), 51 deletions(-) > > DaveM, I'm going to review this patch series (starting on Monday). Is > that acceptable forewarning? :-) > > MBR, Sergey
