Re: [PATCH 00/14] Add functional support for Gigabit Ethernet driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/9/21 10:07 PM, Biju Das wrote:

> The DMAC and EMAC blocks of Gigabit Ethernet IP found on RZ/G2L SoC are
> similar to the R-Car Ethernet AVB IP.
> 
> The Gigabit Ethernet IP consists of Ethernet controller (E-MAC), Internal
> TCP/IP Offload Engine (TOE)  and Dedicated Direct memory access controller
> (DMAC).
> 
> With a few changes in the driver we can support both IPs.
> 
> This patch series is aims to add functional support for Gigabit Ethernet driver
> by filling all the stubs except set_features.
> 
> set_feature patch will send as separate RFC patch along with rx_checksum
> patch, as it needs detailed discussion related to HW checksum.
> 
> Ref:-
>  https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=557655
> 
> RFC->V1:
>  * Removed patch#3 will send it as RFC
>  * Removed rx_csum functionality from patch#7, will send it as RFC
>  * Renamed "nc_queue" -> "nc_queues"
>  * Separated the comment patch into 2 separate patches.
>  * Documented PFRI register bit
>  * Added Sergy's Rb tag

   It's Sergey. :-)

> RFC changes:
>  * used ALIGN macro for calculating the value for max_rx_len.
>  * used rx_max_buf_size instead of rx_2k_buffers feature bit.
>  * moved struct ravb_rx_desc *gbeth_rx_ring near to ravb_private::rx_ring
>    and allocating it for 1 RX queue.
>  * Started using gbeth_rx_ring instead of gbeth_rx_ring[q].
>  * renamed ravb_alloc_rx_desc to ravb_alloc_rx_desc_rcar
>  * renamed ravb_rx_ring_free to ravb_rx_ring_free_rcar
>  * renamed ravb_rx_ring_format to ravb_rx_ring_format_rcar
>  * renamed ravb_rcar_rx to ravb_rx_rcar
>  * renamed "tsrq" variable
>  * Updated the comments
> 
> Biju Das (14):
>   ravb: Use ALIGN macro for max_rx_len
>   ravb: Add rx_max_buf_size to struct ravb_hw_info
>   ravb: Fillup ravb_alloc_rx_desc_gbeth() stub
>   ravb: Fillup ravb_rx_ring_free_gbeth() stub
>   ravb: Fillup ravb_rx_ring_format_gbeth() stub
>   ravb: Fillup ravb_rx_gbeth() stub
>   ravb: Add carrier_counters to struct ravb_hw_info
>   ravb: Add support to retrieve stats for GbEthernet
>   ravb: Rename "tsrq" variable
>   ravb: Optimize ravb_emac_init_gbeth function
>   ravb: Rename "nc_queue" feature bit
>   ravb: Document PFRI register bit
>   ravb: Update EMAC configuration mode comment
>   ravb: Fix typo AVB->DMAC
> 
>  drivers/net/ethernet/renesas/ravb.h      |  17 +-
>  drivers/net/ethernet/renesas/ravb_main.c | 325 +++++++++++++++++++----
>  2 files changed, 291 insertions(+), 51 deletions(-)

   DaveM, I'm going to review this patch series (starting on Monday). Is that acceptable forewarning? :-)

MBR, Sergey



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux