On Fri, Oct 8, 2021 at 2:11 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > On Thu, Oct 7, 2021 at 5:55 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote: > > This patch enables microSD card slot connected to SDHI1 on RZ/G2L SMARC > > platform. > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > Thanks for your patch! > > > --- a/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi > > +++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi > > @@ -70,6 +70,16 @@ > > regulator-min-microvolt = <5000000>; > > regulator-max-microvolt = <5000000>; > > }; > > + > > + vccq_sdhi1: regulator-vccq-sdhi1 { > > + compatible = "regulator-gpio"; > > + regulator-name = "SDHI1 VccQ"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <3300000>; > > + gpios = <&pinctrl RZG2L_GPIO(39, 1) GPIO_ACTIVE_HIGH>; > > Is this correct? Schematics say GPIO high is 3.3V. Yes it is, as per the value "1" in states below. > > + gpios-states = <1>; > > + states = <3300000 1 1800000 0>; > > + }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds