On 8/25/21 10:01 AM, Biju Das wrote: > R-Car uses an extended descriptor in RX whereas, RZ/G2L uses > normal descriptor in RX. Factorise the ravb_rx function to > support the later SoC. > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> [...] > diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c > index 148c974499b4..1cace5324261 100644 > --- a/drivers/net/ethernet/renesas/ravb_main.c > +++ b/drivers/net/ethernet/renesas/ravb_main.c > @@ -562,8 +562,7 @@ static void ravb_rx_csum(struct sk_buff *skb) > skb_trim(skb, skb->len - sizeof(__sum16)); > } > > -/* Packet receive function for Ethernet AVB */ > -static bool ravb_rx(struct net_device *ndev, int *quota, int q) > +static bool ravb_rcar_rx(struct net_device *ndev, int *quota, int q) Mhm, isn't this too large a function to duplicate it all for RZ-G2? [...] MBR, Sergey